2024-05-16 17:31 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0005909Spring engineGeneralpublic2018-02-28 17:45
ReporterGoogle_Frog 
Assigned ToKloot 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version104.0 +git 
Target VersionFixed in Version104.0 +git 
Summary0005909: 104.0.1-257-g02191c9 maintenance Innacurate range rings
DescriptionSome range rings are inaccurate. Attached is a shot of staticarty firing further than its ring.
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files

-Relationships
+Relationships

-Notes

~0018858

Google_Frog (reporter)

I took screenhots lltHill, missileHill, lltFlat and staticarty with https://github.com/spring/spring/commit/2e1a220098aa146aade4df18e2a8df85ed01073a. Overall I think that the range rings are close enough and that any further changes are low priority. For practical purposes, 3D range rings are already slightly inaccurate because weapons usually shoot at targets at a variable height above the ground.

The range rings of living units match those of blueprints, so the original ticket is fixed.

The flat LLT and raised Missile Tower screenshot show range rings with no issues. The raised LLT can not fire as far as its ring would indicate. This is probably because it has spherical range and fires from the top of its turret. To fix this we would need to dynamically read query height (impossible for blueprints) or to make some unitDef which sets effective fire height for range rings. The long ranged artillery rings seem much better than they were before.

~0018859

Kloot (developer)

It should be possible to generate rings relative to the muzzle position but that can wait.
+Notes

-Issue History
Date Modified Username Field Change
2018-02-25 02:44 Google_Frog New Issue
2018-02-25 02:44 Google_Frog File Added: screen00023.jpg
2018-02-28 02:52 Google_Frog File Added: lltHill.jpg
2018-02-28 02:52 Google_Frog File Added: missileHill.jpg
2018-02-28 02:53 Google_Frog File Added: lltFlat.jpg
2018-02-28 02:53 Google_Frog File Added: staticarty.jpg
2018-02-28 03:06 Google_Frog File Added: moreStaticArty.jpg
2018-02-28 03:06 Google_Frog Note Added: 0018858
2018-02-28 17:45 Kloot Assigned To => Kloot
2018-02-28 17:45 Kloot Status new => resolved
2018-02-28 17:45 Kloot Resolution open => fixed
2018-02-28 17:45 Kloot Fixed in Version => 104.0 +git
2018-02-28 17:45 Kloot Note Added: 0018859
+Issue History